Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework for generic fvar<T> support through finite-differences #2929
Framework for generic fvar<T> support through finite-differences #2929
Changes from 28 commits
9faaf42
a26d064
41a551b
11c4a23
e3cb963
051bd8d
e3451d4
21560cf
3435d1b
77e4812
162bf58
9c36e70
fd27178
fd77364
85c9e5e
c09bcf4
9d9d58c
fffc14f
24a9e71
00b1303
3be550d
4209cc9
1536d12
e09096b
880a7d9
b4d9d30
119ca9b
8037cd5
f8d886d
ad303aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't do this, but should these reserves be
y.reserve(y.size() + x.size())
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case, since the aim is to return a container of the same size as
x