ROX-28388: Log the event of an API token creation #14526
+104
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 2a5880c. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14526 +/- ##
==========================================
+ Coverage 49.08% 49.11% +0.02%
==========================================
Files 2522 2523 +1
Lines 184227 184284 +57
==========================================
+ Hits 90434 90510 +76
+ Misses 86585 86568 -17
+ Partials 7208 7206 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
janisz
approved these changes
Mar 7, 2025
rukletsov
reviewed
Mar 7, 2025
| @@ -17,7 +17,8 @@ var ( | |||
| hints = map[string]map[string]map[string]string{ | |||
| authenticationDomain: { | |||
| adminResources.APIToken: { | |||
| "": `An API token is about to expire. See the details on the expiration time within the event message. | |||
| codes.TokenCreated: `An API token has been created.`, | |||
There was a problem hiding this comment.
Suggested change
| codes.TokenCreated: `An API token has been created.`, | |
| codes.TokenCreated: `An API token has been created; consider using machine-to-machine authentication instead.`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Unit tests.
Log message:
apitoken/creation: 2025/03/06 13:21:53.626725 log.go:27: Warn: An API token has been created {"err_code": "token-created", "api_token_name": "Log Token Creation Test", "api_token_id": "3c4f0797-74fd-4ac9-9c5e-dee2a011ef22", "roles": ["Configuration Controller"], "user_id": "sso:4df1b98c-24ed-4073-a9ad-356aec6bb62d:admin", "user_auth_provider": "basic Login with username/password"}Administration event