Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test environment setup #12

Merged
merged 16 commits into from
Oct 10, 2020
Merged

Add unit test environment setup #12

merged 16 commits into from
Oct 10, 2020

Conversation

ChristianMarca
Copy link
Contributor

@ChristianMarca ChristianMarca commented Aug 26, 2020 •
edited
Loading

Description

This PR adds the setup for the testing environment using the Jest and React Native Testing Library

Please check the setup and the test use cases to verify if the testing way is properly before to continue implementing the other tests.

Validations:

  • Unit test.
  • Lint/TSlint

Notes: The peer dependency problem was solved by installing these dependencies as devDependencies this idea was taken from the yarn open issue,

@ChristianMarca ChristianMarca self-assigned this Aug 26, 2020
@ChristianMarca ChristianMarca linked an issue Sep 4, 2020 that may be closed by this pull request
Add tests to the library #4
Closed
ChristianMarca and others added 8 commits September 4, 2020 14:11
flandrade
flandrade reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@flandrade flandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristianMarca Great work so far! I left some small comments, mostly related to BDD with Jest. Here is a small guide to writing better specs.

@ChristianMarca ChristianMarca requested review from flandrade and JoseLion and removed request for flandrade September 28, 2020 13:52
JoseLion
JoseLion reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far! I added some comments you can start checking. I have not finished reviewing everything, but you can address this first batch and check the rest of the code based on the comments. Then we can check it again 🙂

@JoseLion JoseLion changed the title Add unit test environment setup and git hook Add unit test environment setup Oct 1, 2020
JoseLion
JoseLion approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! It a bit of a big PR so please take a careful look at the comments before merging. Good job and thanks for your help! 🎉 🙂

@ChristianMarca
Copy link
Contributor Author

🙏 Thank you @JoseLion This project is amazing and the comments were really useful to clean the code make more readable and scalable 🚀

@ChristianMarca ChristianMarca merged commit 32fdad4 into master Oct 10, 2020
@ChristianMarca ChristianMarca deleted the Add-unit-test-environment-setup-and-git-hook branch October 10, 2020 20:35
@JoseLion
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseLion JoseLion JoseLion approved these changes

@flandrade flandrade Awaiting requested review from flandrade

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests to the library
3 participants
@ChristianMarca @JoseLion @flandrade