fix(cli): handle pnpm catalogs #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just added a valid git url repository url to all package.json files and the packages now are fine (we have git repository type): https://github.com/unocss/unocss/runs/36216006512 Maybe SB registry was wrong? I send a PR to fix the catalogs before running /cc @Aslemammad |
|
all this packages have resolved catalogs properly now without doing anything? |
|
can you point me to the place where they do not resolve catalogs and the place where now they do? so i see the difference and investigate it. |
|
Wrong tgz files when testing uno, check this comment: |
|
in the git url pr it is emitting the right files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles pnpm catalogs including named catalogs with a simple algorithm to replace all
catalog:andcatalog:<name>found in dependencies, devDependencies and peerDependencies before writing first time the package.json file.Right now using
process.cwd()to detectpnpm-workspace.yamlfile to load the catalogs. I need to confirm the logic is fine, check the Catalogs: Shareable dependency version specifiers rfc at pnpm repo./cc @Aslemammad
closes #204