-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extended-files #1427
base: main
Are you sure you want to change the base?
feat: extended-files #1427
Conversation
983b2b5
to
dbb7d1c
Compare
.join('\n\n'); | ||
|
||
const contentWithFilesInfo = textFilesInfo ? `${messageContent}\n\n${textFilesInfo}` : messageContent; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should change the order,
Here is some context from files for your reference\n\n---\n ${textFilesInfo}\n---\n${messageContent}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should change the order,
Here is some context from files for your reference\n\n---\n ${textFilesInfo}\n---\n${messageContent}
Can I reverse the order then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.. the content at the end gets more emphasis, so the AI will know what to do with all the context, if we put that after the context
I just got chance to review the code. looks goof to me.. @leex279 if you can test the functionality and UI then we are good I believe |
will test later today |
Thanks @thecodacus for reviewing the feature! |
Findings PDF-Files look not working properly. Either it gets an error (maybe to big) or it does not use the pdf content as instruction, instead building a pdf viewer :D 2. Building wrong app: 3. Styling could be improved (margin between filebox and chat): |
Can you please test it for me now? @leex279 |
2925271
to
2e6b0e0
Compare
898febe
to
50dd74d
Compare
@thecodacus I ended up deleting the commits of the feature by accident if you can see if I didn't do anything wrong when I recovered the commits please! |
@thecodacus please take a look. I dont know :D ... let me know when I can test/review again :) |
Detailed Summary of Document Processing Feature
The implemented feature introduces a robust system for processing documents and files in the application, with a special focus on PDF and DOCX files. Here is a detailed breakdown of the features:
Document Text Extraction
The core component is the implementation of text extractors for different types of documents:
<w:t>
tagsFile Handling in the Interface
The system also implements a complete interface for uploading and manipulating files:
The feature implements a complete flow from uploading to processing and displaying documents, with a focus on user experience and security, avoiding potential problems with malicious or very large files.
Resource created from request: #1412 @leex279