-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Introduces remember and builds stable eventHandlers on top of it. #1267
Draft
rjrjr
wants to merge
2
commits into
main
Choose a base branch
from
ray/remember-event-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,658
−732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4cdaa3
to
a137249
Compare
Looking promising: override fun eventHandler(
name: String,
update: WorkflowAction<
@UnsafeVariance PropsT,
StateT,
@UnsafeVariance OutputT
>.Updater.() -> Unit
): () -> Unit {
val handler = { actionSink.send(action("eventHandler:$name", update)) }
return if (stableEventHandlers) {
class Box0 {
lateinit var delegate: () -> Unit
fun fire() = delegate()
}
val box = remember("stableEventHandler:$name") { Box0() }
box.delegate = handler
box::fire
} else {
handler
}
} |
rjrjr
commented
Feb 25, 2025
workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/internal/RealRenderContext.kt
Outdated
Show resolved
Hide resolved
95498e2
to
fec7178
Compare
...dungeon/timemachine/src/test/java/com/squareup/sample/timemachine/TimeMachineWorkflowTest.kt
Outdated
Show resolved
Hide resolved
workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/internal/RealRenderContext.kt
Outdated
Show resolved
Hide resolved
workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/internal/WorkflowNode.kt
Show resolved
Hide resolved
workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/WorkflowInterceptor.kt
Show resolved
Hide resolved
fc02943
to
1f63015
Compare
77672ac
to
7348024
Compare
rjrjr
commented
Mar 4, 2025
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Show resolved
Hide resolved
7348024
to
9a11110
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.