Replace deprecated MapManager methods with MapSystem API #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-Kirill
requested review from
metalgearsloth,
PJB3005 and
DrSmugleaf
as code owners
|
big-ass PR also pr from master cringe |
Also failed Build. |
|
This is my first PR( |
In all places where MapManager was deprecated, it was replaced by MapSystem
|
|
Makes it impossible to have multiple prs going at once and also merge conflicts if you ever need to update the pr, just make a new branch for it. |
|
Where I clicked... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all places (almost) where
MapManagerwas deprecated, it was replaced byMapSystem