Fix solo config being not seralizable #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirm this fix myself; this PR Closes #55 |
CamKem
added a commit
to CamKem/solo
that referenced
this pull request
Feb 15, 2025
|
Wonderful fix. Thank you! I wouldn't have guessed it was gonna be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! First up, thanks for the excellent package.
This is a fix for #55 (exception being thrown when caching Laravel config due to the
Commandsclass not being serializable.I tried adding
__serializeand__unserialize, but found it wasn't actually being called. Instead, it was expecting a__set_statefunction, caused by the cache command usingvar_dump.The fix just sets
__set_stateto return a new instance, with every property set to the value set when registered in the confg