Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in ZSH install instructions #483

Closed
jamesbraza opened this issue Feb 28, 2024 · 1 comment · Fixed by #484
Closed

Broken link in ZSH install instructions #483

jamesbraza opened this issue Feb 28, 2024 · 1 comment · Fixed by #484

Comments

@jamesbraza
Copy link

In https://github.com/so-fancy/diff-so-fancy/tree/578bffcc5a7278e708891b224d2637c382c238da?tab=readme-ov-file#install, the README.md points to diff-so-fancy/zsh-frameworks.md, which doesn't actually exist.

Can we update the ZSH install instructions to reflect #482?

Cc @unixorn
@unixorn
Copy link
Contributor

unixorn commented Mar 1, 2024

Crud, fixing now

unixorn added a commit to unixorn/diff-so-fancy that referenced this issue Mar 1, 2024
@unixorn
Fix broken link in README.md
b7887b2 
Closes so-fancy#483

Signed-off-by: Joe Block <[email protected]>
This was referenced Mar 1, 2024
Merged
Open
Merged
scottchiefbaker pushed a commit that referenced this issue Mar 5, 2024
@unixorn
Fix broken link in README.md (#484)
b58488a 
* Fix broken link in README.md

Closes #483

Signed-off-by: Joe Block <[email protected]>

* Updated link per feedback

Signed-off-by: Joe Block <[email protected]>

* Update link per feedback

Remove the `http://...` portion of the link

Signed-off-by: Joe Block <[email protected]>

---------

Signed-off-by: Joe Block <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken link in README.md unixorn/diff-so-fancy
2 participants
@unixorn @jamesbraza