Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum supported async-task version is 4.4.0 #90

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Feb 13, 2024

This crate depends on async_task::Builder, which was introduced in 4.4.0

Detected with cargo-minimal-versions

this crate depends on async_task::Builder, which was introduced in 4.4.0
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@notgull notgull merged commit 0baba46 into smol-rs:master Feb 13, 2024
8 checks passed
@notgull
Copy link
Member

notgull commented Feb 13, 2024

@taiki-e Do you think it would be worth checking cargo-minimal-versions in CI?

@notgull notgull mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants