Add @nullable trait and update proposal
#1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
May 5, 2022
* Move `aws.api#clientOptional` to `smithy.api#nullable`. In order for diff tools to understand backward compatible changes, this trait has to be a core part of Smithy that tooling can reason about. The trait has utility outside of AWS too as it allows any model to define their own backward compatibility guarantees for a required member and does not require teams to ignore Smithy's built-in diff support that checks for allowed `@required` changes. * Remove Smithy 2.0 traits and semantics from 1.0. Adding `@default` and allowing `@nullable` in 1.0 made an already complex nullability story impossibly complex. `@default` and `@nullable` is now only be allowed in Smithy 2.0.
mtdowling
force-pushed
the
add-nullable-trait
branch
from
547135b to
2d4f462
Compare
kstich
reviewed
May 6, 2022
kstich
reviewed
May 9, 2022
JordonPhillips
approved these changes
May 10, 2022
| // Get members that changed. | ||
| differences.changedShapes(MemberShape.class), | ||
| // Get members of structures that added/removed the input trait. | ||
| changedInputMembers(differences) |
There was a problem hiding this comment.
Do members not count as having changed if their traits change?
There was a problem hiding this comment.
Yeah, any change to a member gets picked up. The difference here is that the structure that contains the member changed, so that has to be detected separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws.api#clientOptionaltosmithy.api#nullable. In orderfor diff tools to understand backward compatible changes, this trait has to
be a core part of Smithy that tooling can reason about. The trait has
utility outside of AWS too as it allows any model to define their own
backward compatibility guarantees for a required member and does not
require teams to ignore Smithy's built-in diff support that checks for
allowed
@requiredchanges.@defaultandallowing
@nullablein 1.0 made an already complex nullability storyimpossibly complex.
@defaultand@nullableis now only be allowed inSmithy 2.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.