reduce buffer copies #867
Merged
reduce buffer copies #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/buffer
branch
2 times, most recently
from
3f3c073 to
3833f3e
Compare
kuhe
commented
Mar 8, 2024
| @@ -8,7 +8,7 @@ export const calculateBodyLength = (body: any): number | undefined => { | |||
| return 0; | |||
| } | |||
| if (typeof body === "string") { | |||
| return Buffer.from(body).length; | |||
| return Buffer.byteLength(body); | |||
There was a problem hiding this comment.
Confirmed this works in Node.js 14+
There was a problem hiding this comment.
> Buffer.byteLength('🚀a')
5
> Buffer.from('🚀a').length
5
kuhe
commented
Mar 8, 2024
| @@ -59,7 +59,14 @@ function writeBody( | |||
| // pipe automatically handles end | |||
| body.pipe(httpRequest); | |||
| } else if (body) { | |||
| httpRequest.end(Buffer.from(body as Parameters<typeof Buffer.from>[0])); | |||
| if (Buffer.isBuffer(body) || typeof body === "string") { | |||
| httpRequest.end(body); | |||
There was a problem hiding this comment.
ClientRequest (node:http(s)) and ClientHttp2Stream (node:http2) both accept .end(string) in addition to .end(Buffer).
trivikr
approved these changes
Mar 8, 2024
syall
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes external contrib aws/aws-sdk-js-v3#2612