-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use aggregated client runtime generator #736
Conversation
|
||
writer.write(""); | ||
|
||
writer.addImport(aggregateClientName + "ClientConfig", null, "./src/" + aggregateClientName + "Client"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to avoid duplicating the logic for creating the client config and barebones client type names? Maybe String barebonesClientName = serviceSymbol.getName();
. And I think serviceSymbol.getNamespace()
might give you the "./src/" + aggregateClientName + "Client"
part.
...rc/main/java/software/amazon/smithy/typescript/codegen/ServiceAggregatedClientGenerator.java
Outdated
Show resolved
Hide resolved
|
||
writer.write(""); | ||
|
||
writer.addImport(barebonesClientName + "Config", null, serviceSymbol.getNamespace()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add another method in ServiceBareBonesClientGenerator for getting the config type name, like https://github.com/awslabs/smithy-typescript/blob/a526a73f8fada65c9ef0bddea94a85695229f2c4/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServiceBareBonesClientGenerator.java#L90
ad8ee46
to
f3aeb9e
Compare
Requires aws/aws-sdk-js-v3#4639
Switch to using an aggregated client runtime generator instead of codegen.
before
after
Overall change appears to be around -2% to -3% dist-cjs.