Support JMESPath flatten in OperationContextParams #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
op-context-params-flatten
branch
from
121df98 to
b4efe8e
Compare
siddsriv
reviewed
Feb 27, 2025
| value = value + separator + key.substring(0, key.length() - 3) + ".flat()"; | ||
| } else { | ||
| // key is on object | ||
| value = value + separator + key + ").flat()"; |
There was a problem hiding this comment.
spec question i believe: will there always be an opening parenthesis? since we are doing a concatenation with ").flat()"
There was a problem hiding this comment.
Yes. When the key is on object, there's already a map function on it which needs to be closed before flatten can be called.
kuhe
approved these changes
Feb 27, 2025
siddsriv
approved these changes
Feb 27, 2025
This was referenced Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Support JMESPath flatten in OperationContextParams
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.