fix(middleware-endpoint): check for s3 arn parts #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in this issue smithy-lang#1121 arn check should not check s3 arns contain nor account nor region since they are not part of s3 arns
kuhe
approved these changes
Apr 3, 2024
kuhe
reviewed
Apr 3, 2024
| @@ -61,9 +61,10 @@ export const isDnsCompatibleBucketName = (bucketName: string): boolean => | |||
| export const isArnBucketName = (bucketName: string): boolean => { | |||
| const [arn, partition, service, region, account, typeOrId] = bucketName.split(":"); | |||
| const isArn = arn === "arn" && bucketName.split(":").length >= 6; | |||
| const isValidArn = [arn, partition, service, account, typeOrId].filter(Boolean).length === 5; | |||
| const isValidArn = | |||
| [arn, partition, service, typeOrId].filter(Boolean).length === 4 && [region, account].filter(Boolean).length == 0; | |||
There was a problem hiding this comment.
We cannot require that region and account are definitively not set.
An access point MRAP ARN works with and without the account id present, for example with listObjects({ Bucket: "arn:aws:s3::12345:accesspoint/xyz.mrap" })
|
I amended the PR to only make account id segment of the ARN optional, not to require that it is not present. |
AndrewFossAWS
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in this issue #1121 arn check should not check s3 arns contain nor account nor region since they are not part of s3 arns
Issue #, if available:
#1121
Description of changes:
Check S3 arn is valid by not expecting account nor region to be in the arn (fail if any of those two are present)
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.