feat: paginator factory applied to codegen #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/pagination
branch
from
7dd4879 to
8fa261e
Compare
8 tasks
kuhe
force-pushed
the
feat/pagination
branch
from
8fa261e to
f050a85
Compare
kuhe
changed the title
kuhe
force-pushed
the
feat/pagination
branch
2 times, most recently
from
d2151e2 to
d582195
Compare
syall
approved these changes
Dec 18, 2023
|
CI expected to fail until #1115 is merged, but approving in the meantime. |
kuhe
force-pushed
the
feat/pagination
branch
from
d582195 to
66881c6
Compare
mtdowling
reviewed
Dec 18, 2023
...ipt-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java
Outdated
Show resolved
Hide resolved
kuhe
force-pushed
the
feat/pagination
branch
from
66881c6 to
6ee7c12
Compare
mtdowling
approved these changes
Dec 19, 2023
trivikr
pushed a commit
to trivikr/smithy-typescript
that referenced
this pull request
Dec 27, 2023
* feat: paginator factory * feat: paginator use pushState * feat: paginator, clean up syntax * feat: paginator, add dependency
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR requires that #1115 be merged and published