-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS24004106/MOVEA from Scalar to Standalone array #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't like about this solution is that you are addressing, what might be a more serious issue, specifically for MOVEA
. I recall seeing the same symptoms in #613, where you fixed the assignment logic in InternalInterpreter.set
, which I found to be a good solution.
I'm concerned that if each operation code requires its own implementation for assignment logic from scalar to vector—which should be a common behavior in Jariko—it might take years to cover all possible use cases.
For this reason, you should also try with EVAL
and all MOVEx
operation codes.
I agree with you. I could check with |
Description
This work adds the capability to use
MOVEA
from a scalar to a Standalone array declared as:Technical notes
Previous this fix, Jariko didn't take into consideration about result type when the second parameter of
MOVEA
was a scalar. For example:It constructed the array as integer and not as decimal. More precisely, must be a decimal with number arranged from least significant digit. This problem covered
MOVE
,MOVEL
andEVAL
too.So, now constructs the right array based of type.
Related to #LS24004106
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.