-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS24004086/MOVEA from Array field to Standalone #614
Merged
lanarimarco
merged 16 commits into
develop
from
bugfix/LS24004086/movea-from-array-field-to-s
Sep 23, 2024
Merged
Bugfix/LS24004086/MOVEA from Array field to Standalone #614
lanarimarco
merged 16 commits into
develop
from
bugfix/LS24004086/movea-from-array-field-to-s
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay-field-to-s' into bugfix/LS24004086/movea-from-array-field-to-s
…rted with `EXTNAME` for a DS.
lanarimarco
requested changes
Sep 23, 2024
rpgJavaInterpreter-core/src/test/resources/smeup/MUDRNRAPU00117.rpgle
Outdated
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/test/resources/smeup/MUDRNRAPU00118.rpgle
Outdated
Show resolved
Hide resolved
rpgJavaInterpreter-core/src/test/resources/smeup/MUDRNRAPU00119.rpgle
Outdated
Show resolved
Hide resolved
… `MUDRNRAPU00119`
lanarimarco
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the merge something went wrong.
These tests:
08b3413
are disappeared.
… because are in another branch
lanarimarco
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work adds the capability to use
MOVEA
from an array declared as DS' field to a Standalone definition. For example:Also, provides to fix the "overlay" of a DS field, imported by using
EXTNAME
, and another declared with offset. Under the hood, by considering previous example, we have a DS built with fields provided fromAUTOAP0F
and a new field (AU1
) declared with offset. This offset corresponds with some field provided fromAUTOAP0F
. So, the value forAU1
might be the value for another field.Technical notes
For the first cause, related to
MOVEA
, I fixed the problem by adding toProjectedArrayValue
class the implementation forelementSize
,takeAll
,takeFirst
,takeLast
.For the second cause, "overlay" of two field by using
EXTNAME
:knowDataDefinitions
from files by ignoring data definitions declared withoutEXTNAME
;RpgParser.Parm_fixedContext.toFieldInfo
the fields declared in a file imported withEXTNAME
.Related to #LS24004086
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.