Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ls24003456/comptime like api #573

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Bugfix/ls24003456/comptime like api #573

merged 5 commits into from
Jul 18, 2024

Conversation

dom-apuliasoft
Copy link
Collaborator

@dom-apuliasoft dom-apuliasoft commented Jul 18, 2024 •
edited
Loading

Description

Add support for comptime resolution of variables referencing symbols in API directives.

Related to:

  • LS24003456

Checklist:

  • There are tests regarding this feature
  • The code follows the Kotlin conventions (run ./gradlew ktlintCheck)
  • The code passes all tests (run ./gradlew check)
  • There is a specific documentation in the docs directory

lanarimarco
lanarimarco approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use the right functions, even a challenging issue becomes simpler than I thought.
Very good job.

@lanarimarco lanarimarco merged commit 1e2657e into develop Jul 18, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24003456/comptime-like-api branch July 18, 2024 14:16
@lanarimarco lanarimarco mentioned this pull request Jul 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanarimarco lanarimarco lanarimarco approved these changes

@benetti-smeup benetti-smeup Awaiting requested review from benetti-smeup benetti-smeup is a code owner

@mattiabonardi mattiabonardi Awaiting requested review from mattiabonardi mattiabonardi is a code owner

@FiorenzaBusi FiorenzaBusi Awaiting requested review from FiorenzaBusi FiorenzaBusi is a code owner

@cosentino-smeup cosentino-smeup Awaiting requested review from cosentino-smeup cosentino-smeup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dom-apuliasoft @lanarimarco