Bugfix/nw23001440/262 mock oc feod

[davidepalladino-apuliasoft]

Description

Firstly, for this task was created an interface for those operators mocked, with a refactoring of previous implementation. Then, created the FeodStmt so that Jariko no longer crashes.

Checklist:

• There are tests regarding this feature
• The code follows the Kotlin conventions (run ./gradlew ktlintCheck)
• The code passes all tests (run ./gradlew check)
• There is a specific documentation in the docs directory

[lanarimarco]

If we implement mock statement like this we have no idea if a codop works because is good or because is silly :-).
My proposal is:

• Define a MockStatement empty interface
• All mocked statements should implement that interface
• Define a new callback function JarikoCallback.onMockStatement: (mockStatement: MockStatement) -> Unit with default implementation: System.err.println("Executing mock.... bla bla bla...");
• Before of statement.execute if statement is MockStatement invoke MainExecutionContext.getConfiguration().jarikoCallback.onMockStatement(statement)

This way we can log this warning but in addition, we are able to delegate something other to make blocking the codop mock implementation.

If you want to speak at voice I am here.

[davidepalladino-apuliasoft]

If we implement mock statement like this we have no idea if a codop works because is good or because is silly :-). My proposal is:

* Define a  `MockStatement` empty interface

* All mocked statements should implement that interface

* Define a new callback function `JarikoCallback.onMockStatement: (mockStatement: MockStatement) -> Unit` with default implementation: `System.err.println("Executing mock.... bla bla bla...");`

* Before of [statement.execute](https://github.com/smeup/jariko/blob/fa7fc7b84c989c64e7dc713a9f68f8ff7d2645f3/rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/internal_interpreter.kt#L414) if statement is `MockStatement` invoke `MainExecutionContext.getConfiguration().jarikoCallback.onMockStatement(statement)`

This way we can log this warning but in addition, we are able to delegate something other to make blocking the codop mock implementation.

If you want to speak at voice I am here.

Could MockStatement extends Statement?

[lanarimarco]

Yes Il giorno ven 22 mar 2024 alle ore 15:49 Davide ***@***.***> ha scritto:

…

If we implement mock statement like this we have no idea if a codop works because is good or because is silly :-). My proposal is: * Define a `MockStatement` empty interface * All mocked statements should implement that interface * Define a new callback function `JarikoCallback.onMockStatement: (mockStatement: MockStatement) -> Unit` with default implementation: `System.err.println("Executing mock.... bla bla bla...");` * Before of [statement.execute](https://github.com/smeup/jariko/blob/fa7fc7b84c989c64e7dc713a9f68f8ff7d2645f3/rpgJavaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/interpreter/internal_interpreter.kt#L414) if statement is `MockStatement` invoke `MainExecutionContext.getConfiguration().jarikoCallback.onMockStatement(statement)` This way we can log this warning but in addition, we are able to delegate something other to make blocking the codop mock implementation. If you want to speak at voice I am here. Could MockStatement extends Statement? — Reply to this email directly, view it on GitHub <#474 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJR622U5LXEDJD4G6CR6KI3YZRAG5AVCNFSM6AAAAABFDK2QEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGI3DMNZWG4> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- [image: smeup] <https://www.smeup.com> Marco Lanari R&D Department - Developer Office: 0521940611 <00390521940611> www.smeup.com *SMEUP LAB SRL* Via Carra, 8 - 43122 Parma (PR) [image: smeup] <https://bit.ly/43hyvY0>

[davidepalladino-apuliasoft]

Yes Il giorno ven 22 mar 2024 alle ore 15:49 Davide @.> ha scritto:
…
If we implement mock statement like this we have no idea if a codop works because is good or because is silly :-). My proposal is: * Define a MockStatement empty interface * All mocked statements should implement that interface * Define a new callback function JarikoCallback.onMockStatement: (mockStatement: MockStatement) -> Unit with default implementation: System.err.println("Executing mock.... bla bla bla..."); * Before of statement.execute if statement is MockStatement invoke MainExecutionContext.getConfiguration().jarikoCallback.onMockStatement(statement) This way we can log this warning but in addition, we are able to delegate something other to make blocking the codop mock implementation. If you want to speak at voice I am here. Could MockStatement extends Statement? — Reply to this email directly, view it on GitHub <#474 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJR622U5LXEDJD4G6CR6KI3YZRAG5AVCNFSM6AAAAABFDK2QEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGI3DMNZWG4 . You are receiving this because your review was requested.Message ID: @.>
-- [image: smeup] https://www.smeup.com Marco Lanari R&D Department - Developer Office: 0521940611 <00390521940611> www.smeup.com SMEUP LAB SRL Via Carra, 8 - 43122 Parma (PR) [image: smeup] https://bit.ly/43hyvY0

Ok, the idea is perfect and clean. Check new commits