Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/nw23001440/247 data definition #462

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

davidepalladino-apuliasoft
Copy link
Collaborator

Description

The main problem was the resolution of startOffset for that field that is not an overlay, next to another that is it. Considering this code:

     D A40_DS10A                      5    DIM(3)
     D  DS10A_FL1                     2    OVERLAY(A40_DS10A:01)
     D  DS10A_FL2                     3    OVERLAY(A40_DS10A:*NEXT)
     D A40_DS10B                      9    DIM(3)
     D  DS10B_FL1                     4    OVERLAY(A40_DS10B:01)
     D  DS10B_FL2                     5    OVERLAY(A40_DS10B:*NEXT)

the previous implementation attempted to resolve it by the endOffsetIncludingAllElement of previous field. In this case DS10A_FL2 that is an overlay. To fix the problem I put a searching of the first definition of field that is not an overlay.

Checklist:

  • There are tests regarding this feature
  • The code follows the Kotlin conventions (run ./gradlew ktlintCheck)
  • The code passes all tests (run ./gradlew check)
  • There is a specific documentation in the docs directory

Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move test in MULANGT02ConstAndDSpecTest

lanarimarco
lanarimarco previously approved these changes Mar 19, 2024
Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@lanarimarco
Copy link
Collaborator

Fix conflicts

@lanarimarco lanarimarco self-assigned this Mar 19, 2024
@lanarimarco lanarimarco merged commit 3a035c4 into develop Mar 20, 2024
1 check failed
@lanarimarco lanarimarco deleted the bugfix/NW23001440/247-data-definition branch March 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants