Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback pr #338 and fixed warnings #343

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Rollback pr #338 and fixed warnings #343

merged 1 commit into from
Jul 27, 2023

Conversation

lanarimarco
Copy link
Collaborator

Description

Rollback pr #338 and fixed warnings

Checklist:

  • There are tests regarding this feature
  • The code follows the Kotlin conventions (run ./gradlew ktlintCheck)
  • The code passes all tests (run ./gradlew check)
  • There is a specific documentation in the docs directory

FiorenzaBusi
FiorenzaBusi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@FiorenzaBusi FiorenzaBusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, change for rollback

@FiorenzaBusi FiorenzaBusi merged commit 954950d into develop Jul 27, 2023
@lanarimarco lanarimarco deleted the bugfix/NW23000322_like_def_rollback branch September 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FiorenzaBusi FiorenzaBusi FiorenzaBusi approved these changes

@benetti-smeup benetti-smeup Awaiting requested review from benetti-smeup benetti-smeup is a code owner

@mattiabonardi mattiabonardi Awaiting requested review from mattiabonardi mattiabonardi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanarimarco @FiorenzaBusi