Bugfix/figurative constants resolution #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for all constants when used in factor1 - in both factors if constants were *ON and *OFF - in both factors when opcode were a comparison operator, for instance IFxx or ANDxx Note: ERROR08.rpgle is changed because *OFF constant resolution was fixed, and I had to force others type of errors in order to preserve callback errors test cases
lanarimarco
requested review from
benetti-smeup and
mattiabonardi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Figurative constants symbol *ON and *OFF, and *INnn were never resolved.
None constant was resolved when used in factor1 and in both factors, in case of comparison type codop.
Related to #307
Checklist:
./gradlew ktlintCheck)./gradlew check)docsdirectory