fix: use node 22 #4081
Merged
fix: use node 22 #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <[email protected]>
# Summary Update pre-submit to use ubuntu24 https://github.com/slsa-framework/slsa-github-generator/actions/runs/12999310515/job/36254511524?pr=4041 ``` Run ./.github/workflows/scripts/pre-submit.e2e.go.default.sh ✖ ubuntu24 == ubuntu22 :: .predicate.invocation.environment.os should be ubuntu22 Error: Process completed with exit code 1. ``` ## Testing Process This PR's pre-submits should pass. ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [ ] Update documentation if applicable. - [x] Add unit tests if applicable. - [ ] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
ramonpetgrave64
force-pushed
the
ramonpetgrave64-patch-4
branch
from
364d89f to
61917d6
Compare
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
loosebazooka
approved these changes
Jan 28, 2025
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
start using node22 in all our actions and pre-submits.
re: #4001
Testing Process
The pre-submits in this PR should pass.
Checklist