fix: wipe (P)MBR with GPT #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When wiping GPT, also wipe the zeroth sector with MBR. Signed-off-by: Andrey Smirnov <[email protected]>
frezbo
approved these changes
Feb 12, 2025
Unix4ever
approved these changes
Feb 12, 2025
dsseng
approved these changes
Feb 12, 2025
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 12, 2025
Fixes siderolabs#10292 This pulls in fixes from go-blockdevice library: * siderolabs/go-blockdevice#127 * siderolabs/go-blockdevice#128 Also allow `megaraid` emulation in `talosctl cluster create`. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 13, 2025
Fixes siderolabs#10292 This pulls in fixes from go-blockdevice library: * siderolabs/go-blockdevice#127 * siderolabs/go-blockdevice#128 Also allow `megaraid` emulation in `talosctl cluster create`. Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit 8531d91)
samip5
pushed a commit
to skyssolutions/talos
that referenced
this pull request
Feb 13, 2025
Fixes siderolabs#10292 This pulls in fixes from go-blockdevice library: * siderolabs/go-blockdevice#127 * siderolabs/go-blockdevice#128 Also allow `megaraid` emulation in `talosctl cluster create`. Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit 8531d91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wiping GPT, also wipe the zeroth sector with MBR.