Add immediate saving of every line of input to history file #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By writing history after each input line, we avoid losing history if numbat fails to exit gracefully.
|
Thank you very much!
Sounds okay to me, I don't think it's a particularly common error, hopefully. Thank you for bringing it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation shows an error after every line of input if appending to the history file fails. I could see this being annoying, but at the same time it is the safe option compared to only showing the warning once and having a user think they've fixed their issue with the history file, and then having it turn out they didn't, and having their history silently lost.