Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster lists #478

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Faster lists #478

merged 2 commits into from
Jul 1, 2024

Conversation

sharkdp
Copy link
Owner

@sharkdp sharkdp commented Jun 23, 2024 •
edited
Loading

See #448

Benchmark

sum(map(sqrt, range(0, 10000)))
state time [s]
master 12.4
remove unnecessary cloning of values in VM 6.7

The next biggest problem is that GetLocal ops clone the entire list. Maybe we can use Cow<Value>?

@sharkdp sharkdp changed the title Remove unnecessary cloning in VM Faster lists Jul 1, 2024
@sharkdp sharkdp marked this pull request as ready for review July 1, 2024 17:44
@sharkdp sharkdp merged commit 8abc7d4 into master Jul 1, 2024
15 checks passed
@sharkdp sharkdp deleted the faster-lists branch July 1, 2024 17:44
@sharkdp
Copy link
Owner Author

sharkdp commented Jul 1, 2024

I guess there is no harm in merging this as-is.

@sharkdp sharkdp mentioned this pull request Jul 1, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sharkdp