Add function to solve quadratic equations #398

hamirmahal · 2024-03-13T07:34:35Z

closes #397.

numbat/src/ffi.rs

numbat/src/value.rs

numbat/modules/math/functions.nbt

triallax · 2024-03-13T20:41:24Z

Since we're returning a string now, might as well implement the function directly in Numbat (as shown in #397 (comment))?

triallax · 2024-03-13T20:46:38Z

Also can you change the commit message to "Add function to solve quadratic equations"?

book/src/list-functions.md

hamirmahal · 2024-03-13T21:56:21Z

Since we're returning a string now, might as well implement the function directly in Numbat (as shown in #397 (comment))?

Either way is fine. Feel free to close this if this isn't something you want to add.

triallax · 2024-03-13T22:29:56Z

I'm fine with adding it to Numbat myself (no idea about @sharkdp), it's just that I don't see a good reason to do it via FFI'ing to Rust instead of implementing it directly in numbat/modules as Numbat code.

numbat/modules/math/functions.nbt

numbat/tests/interpreter.rs

numbat/modules/math/functions.nbt

numbat/tests/interpreter.rs

triallax

LGTM, thanks!

hamirmahal · 2024-03-17T07:39:02Z

You're welcome!

numbat/modules/math/functions.nbt

hamirmahal · 2024-03-20T20:04:44Z

I renamed it from solve_quadratic_equation to quadratic_equation because the solver doesn't show up as a suggestion when typing in quad otherwise.

sharkdp · 2024-03-25T07:14:07Z

How about we move this to a module in extra:: and make it "opt in"? Something like extra::algebra. Then I'd be fine with merging it.

hamirmahal · 2024-03-25T18:23:33Z

(signal: 11, SIGSEGV: invalid memory reference)

https://github.com/sharkdp/numbat/actions/runs/8424920106/job/23069903095?pr=398#step:8:267

I'm not too sure what caused that, or how to fix it.

When I try to reproduce the issue locally I get a different error.

hamir@hamir-desktop:~/numbat (feat/functionality-for-quadratic-equation)$ cargo build --locked --release --target=x86_64-apple-darwin
   Compiling libc v0.2.152
   Compiling cfg-if v1.0.0
   Compiling proc-macro2 v1.0.78
   Compiling generic-array v0.14.7
   Compiling typenum v1.17.0
   Compiling siphasher v0.3.11
   Compiling num-traits v0.2.17
   Compiling phf_shared v0.11.2
   Compiling rand_core v0.6.4
   Compiling regex-syntax v0.8.2
   Compiling rand v0.8.5
   Compiling quote v1.0.35
   Compiling cc v1.0.83
   Compiling syn v2.0.48
   Compiling bitflags v2.4.2
   Compiling tinyvec_macros v0.1.1
   Compiling getrandom v0.2.12
   Compiling rustix v0.38.30
   Compiling tinyvec v1.6.0
   Compiling errno v0.3.8
   Compiling phf_generator v0.11.2
   Compiling crypto-common v0.1.6
   Compiling block-buffer v0.10.4
   Compiling spin v0.9.8
   Compiling untrusted v0.9.0
   Compiling regex-automata v0.4.4
   Compiling rustls-pki-types v1.1.0
   Compiling option-ext v0.2.0
   Compiling serde v1.0.195
   Compiling dirs-sys v0.4.1
   Compiling digest v0.10.7
   Compiling unicode-normalization v0.1.22
   Compiling ring v0.17.7
   Compiling phf_codegen v0.11.2
   Compiling phf v0.11.2
   Compiling num-integer v0.1.45
   Compiling cpufeatures v0.2.12
   Compiling log v0.4.20
   Compiling itoa v1.0.10
   Compiling unicode-bidi v0.3.15
   Compiling percent-encoding v2.3.1
   Compiling rustls v0.22.2
   Compiling utf8parse v0.2.1
   Compiling same-file v1.0.6
   Compiling sha2 v0.10.8
The following warnings were emitted during compilation:

warning: [email protected]: cc: error: unrecognized debug output level ‘full’
warning: [email protected]: cc: error: unrecognized command-line option ‘-arch’

error: failed to run custom build command for `ring v0.17.7`

Caused by:
  process didn't exit successfully: `/home/hamir/numbat/target/release/build/ring-393541a1edcf127a/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
  cargo:rustc-env=RING_CORE_PREFIX=ring_core_0_17_7_
  OPT_LEVEL = Some("3")
  TARGET = Some("x86_64-apple-darwin")
  HOST = Some("x86_64-unknown-linux-gnu")
  cargo:rerun-if-env-changed=CC_x86_64-apple-darwin
  CC_x86_64-apple-darwin = None
  cargo:rerun-if-env-changed=CC_x86_64_apple_darwin
  CC_x86_64_apple_darwin = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  RUSTC_LINKER = None
  cargo:rerun-if-env-changed=CROSS_COMPILE
  CROSS_COMPILE = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  CARGO_CFG_TARGET_FEATURE = Some("cmpxchg16b,fxsr,sse,sse2,sse3,sse4.1,ssse3")
  cargo:rerun-if-env-changed=CFLAGS_x86_64-apple-darwin
  CFLAGS_x86_64-apple-darwin = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_apple_darwin
  CFLAGS_x86_64_apple_darwin = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-arch" "x86_64" "-I" "include" "-I" "/home/hamir/numbat/target/x86_64-apple-darwin/release/build/ring-4e4393dd11ac0c15/out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-pedantic" "-Wall" "-Wextra" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-gfull" "-DNDEBUG" "-o" "/home/hamir/numbat/target/x86_64-apple-darwin/release/build/ring-4e4393dd11ac0c15/out/crypto/curve25519/curve25519.o" "-c" "crypto/curve25519/curve25519.c"
  exit status: 1
  cargo:warning=cc: error: unrecognized debug output level ‘full’

  cargo:warning=cc: error: unrecognized command-line option ‘-arch’


  --- stderr


  error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-arch" "x86_64" "-I" "include" "-I" "/home/hamir/numbat/target/x86_64-apple-darwin/release/build/ring-4e4393dd11ac0c15/out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-pedantic" "-Wall" "-Wextra" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-gfull" "-DNDEBUG" "-o" "/home/hamir/numbat/target/x86_64-apple-darwin/release/build/ring-4e4393dd11ac0c15/out/crypto/curve25519/curve25519.o" "-c" "crypto/curve25519/curve25519.c" with args "cc" did not execute successfully (status code exit status: 1).

sharkdp · 2024-03-26T18:25:23Z

book/src/list-functions.md

@@ -74,6 +74,7 @@ fn sech(x: Scalar) -> Scalar
 fn asech(x: Scalar) -> Scalar
 fn csch(x: Scalar) -> Scalar
 fn acsch(x: Scalar) -> Scalar
+fn quadratic_equation<A2, B2>(a: A2, b: B2, c: B2²/A2) -> String


Can we please move this to a new algebra section at the bottom of this page?

Sure, let me know if 5c7f33b isn't what you wanted.

section at the bottom of `list-functions.md`

sharkdp

Thank you

hamirmahal · 2024-03-27T07:17:14Z

You're welcome!

hamirmahal · 2024-03-27T07:18:10Z

Thank you for building this really awesome tool, and thank you for building it with Rust.

sharkdp · 2024-03-27T07:35:37Z

Changes are live on numbat.dev

This reverts commit a3d64f3.

triallax · 2024-03-27T12:05:33Z

Thanks!

hamirmahal · 2024-03-27T20:32:04Z

You're welcome!

hamirmahal commented Mar 13, 2024

View reviewed changes

numbat/src/ffi.rs Outdated Show resolved Hide resolved

numbat/src/value.rs Outdated Show resolved Hide resolved

numbat/modules/math/functions.nbt Outdated Show resolved Hide resolved

triallax reviewed Mar 13, 2024

View reviewed changes

book/src/list-functions.md Outdated Show resolved Hide resolved

triallax mentioned this pull request Mar 13, 2024

Add a list datatype #261

Closed

hamirmahal changed the title ~~feat: functionality for quadratic equation~~ Add function to solve quadratic equations Mar 13, 2024

triallax suggested changes Mar 14, 2024

View reviewed changes

numbat/modules/math/functions.nbt Outdated Show resolved Hide resolved

sharkdp reviewed Mar 14, 2024

View reviewed changes

numbat/tests/interpreter.rs Outdated Show resolved Hide resolved

hamirmahal commented Mar 14, 2024

View reviewed changes

numbat/modules/math/functions.nbt Outdated Show resolved Hide resolved

triallax suggested changes Mar 15, 2024

View reviewed changes

numbat/tests/interpreter.rs Outdated Show resolved Hide resolved

sharkdp reviewed Mar 15, 2024

View reviewed changes

numbat/tests/interpreter.rs Outdated Show resolved Hide resolved

hamirmahal commented Mar 15, 2024

View reviewed changes

numbat/tests/interpreter.rs Outdated Show resolved Hide resolved

hamirmahal requested review from sharkdp and triallax March 15, 2024 20:11

triallax approved these changes Mar 17, 2024

View reviewed changes

triallax reviewed Mar 20, 2024

View reviewed changes

numbat/modules/math/functions.nbt Outdated Show resolved Hide resolved

hamirmahal added 2 commits March 25, 2024 11:00

Add function to solve quadratic equations

03c167d

fix: failure for modules_are_self_consistent

5e54b14

test if error is reproducible

183ea42

sharkdp reviewed Mar 26, 2024

View reviewed changes

docs: move quadratic_equation to a new Algebra

5c7f33b

section at the bottom of `list-functions.md`

sharkdp approved these changes Mar 27, 2024

View reviewed changes

sharkdp merged commit a3d64f3 into sharkdp:master Mar 27, 2024
15 checks passed

hamirmahal deleted the feat/functionality-for-quadratic-equation branch March 27, 2024 07:17

sharkdp added a commit that referenced this pull request Mar 27, 2024

Revert "Add function to solve quadratic equations (#398)"

ce20fc7

This reverts commit a3d64f3.

BrewTestBot mentioned this pull request May 26, 2024

numbat 1.12.0 Homebrew/homebrew-core#172891

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add function to solve quadratic equations #398

Add function to solve quadratic equations #398

hamirmahal commented Mar 13, 2024

triallax commented Mar 13, 2024

triallax commented Mar 13, 2024

hamirmahal commented Mar 13, 2024

triallax commented Mar 13, 2024 •

edited

Loading

triallax left a comment

hamirmahal commented Mar 17, 2024

hamirmahal commented Mar 20, 2024

sharkdp commented Mar 25, 2024

hamirmahal commented Mar 25, 2024

sharkdp Mar 26, 2024

hamirmahal Mar 26, 2024

sharkdp left a comment

hamirmahal commented Mar 27, 2024

hamirmahal commented Mar 27, 2024

sharkdp commented Mar 27, 2024

triallax commented Mar 27, 2024

hamirmahal commented Mar 27, 2024

Add function to solve quadratic equations #398

Add function to solve quadratic equations #398

Conversation

hamirmahal commented Mar 13, 2024

triallax commented Mar 13, 2024

triallax commented Mar 13, 2024

hamirmahal commented Mar 13, 2024

triallax commented Mar 13, 2024 • edited Loading

triallax left a comment

Choose a reason for hiding this comment

hamirmahal commented Mar 17, 2024

hamirmahal commented Mar 20, 2024

sharkdp commented Mar 25, 2024

hamirmahal commented Mar 25, 2024

sharkdp Mar 26, 2024

Choose a reason for hiding this comment

hamirmahal Mar 26, 2024

Choose a reason for hiding this comment

sharkdp left a comment

Choose a reason for hiding this comment

hamirmahal commented Mar 27, 2024

hamirmahal commented Mar 27, 2024

sharkdp commented Mar 27, 2024

triallax commented Mar 27, 2024

hamirmahal commented Mar 27, 2024

triallax commented Mar 13, 2024 •

edited

Loading