Pretty print 'long' units with long prefixes #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to use this to signal that some units don't allow short prefixes, but as of now, I've just made the least ammount of changes to keep the current behavior and have the tests running.
Before this, we had:
```
>>> @metric_prefixes
unit points
@metric_prefixes
unit points
>>> megapoints
megapoints
= 1 Mpoints
```
Now we have:
```
>>> @metric_prefixes
unit points
@metric_prefixes
unit points
>>> megapoints
megapoints
= 1 megapoints
```
I've also added a roundtrip test.
do-you-dare
force-pushed
the
133-prefix
branch
from
9a5fcce to
9a2cdc1
Compare
sharkdp
reviewed
Feb 5, 2024
sharkdp
reviewed
Feb 5, 2024
sharkdp
reviewed
Feb 5, 2024
sharkdp
approved these changes
Feb 5, 2024
triallax
suggested changes
Feb 5, 2024
Before this, it accepted a string and a AcceptsPrefix that were used to construct a CanonicalName internally. This also applies fixes suggested on the PR review [1], such as AcceptsPrefix inconsistencies on tests, code duplication on get_canonical_unit_name. [1]:sharkdp#309
|
Oh, hold on. This isn't actually fixed completely. Try typing |
sharkdp
pushed a commit
that referenced
this pull request
Feb 6, 2024
Before this, it accepted a string and a AcceptsPrefix that were used to construct a CanonicalName internally. This also applies fixes suggested on the PR review [1], such as AcceptsPrefix inconsistencies on tests, code duplication on get_canonical_unit_name. [1]:#309
|
Thanks for the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is related to #133. Any feedbacks are welcome.
I've run the test case on the issue description and it seems to work as expected.
cargo testpasses with no errors and I've added a roundtrip check as required as well.If you want, I can squash or change the commits to better fit the project as well