style: open sharkdp/numbat in new tab
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this changeScreencast.from.01-29-2024.12.33.08.AM.webm |
With this changeScreencast.from.01-29-2024.12.34.07.AM.webm |
|
No comment on the style changes, but the change to open in a new tab LGTM |
|
It's not a style change, this is just the dark mode of the website (if you set your browser to: "prefers theme: dark"). Or are you talking about the formatting changes in the HTML file? @hamirmahal can you please revert those? |
|
I put |
|
@sharkdp I removed the formatting changes. |
I meant whitespace style, sorry for the confusion |
sharkdp
reviewed
Jan 31, 2024
sharkdp
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #302.