Run cargo clippy --fix on codebase

[0xAdk]

I noticed there was a lot of simple clippy lints that clippy --fix was able to resolve.

the lints it didn't have a fix for were:

• clippy::collapsible_match
• clippy::result_large_err
• clippy::needless_bool
• clippy::incorrect_partial_ord_impl_on_ord_type

Since I have a global ~/.config/rustfmt/rustfmt.toml I added the empty rustfmt.toml to override it.

[sharkdp]

Thank you

Since I have a global ~/.config/rustfmt/rustfmt.toml I added the empty rustfmt.toml to override it.

Can we please remove it from this PR?

[0xAdk]

should I include it in another pr? or is there a reason to not have a rustfmt included with the project?

[sharkdp]

Thank you for the update

Is it a recommended practice to put an empty rustfmt.toml file? I don't have that in any of my projects, and it has worked well so far.

(personally, I'd rather question the practice of having a global — instead of project-centric — rustfmt config)

[0xAdk]

I don't think it's recommended anywhere, but it fixed the issue.

personally, I'd rather question the practice of having a global — instead of project-centric — rustfmt config

that's fair... I had it for all the small projects I created but at some point I just defaulted to setting up rust projects with cargo init; cp ~/.config/rustfmt/rustfmt.toml ./rustfmt.toml; cargo fmt, so I can probably just mv the rustfmt.toml file somewhere else and not have it act globally.