Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line highlight #453

Merged
merged 8 commits into from
Dec 18, 2018
Merged

Line highlight #453

merged 8 commits into from
Dec 18, 2018

Conversation

sharkdp
Copy link
Owner

@sharkdp sharkdp commented Dec 16, 2018

Continuing the work of #346 (/CC @tskinn)

  • Allow for multiple occurrences of --highlight-line <N>
  • Highlight the full line
  • Proper handling for overlong lines

image

image

closes #175

@sharkdp sharkdp mentioned this pull request Dec 16, 2018
@sharkdp sharkdp merged commit 668c8a6 into master Dec 18, 2018
@sharkdp sharkdp deleted the line-highlight branch December 18, 2018 08:06
@finviman
Copy link

finviman commented Jan 9, 2019

Great! it makes bat a more useful tool when integrating with other programs such as rg, fzf, etc.
but when will you release a new version with this feature? i use brew in mac, but it only install the v0.9.0 and i can not build from source.

@ReggieMarr
Copy link

ReggieMarr commented Mar 26, 2019

What happened here with regards to highlighting multiple lines ? Is that subfeature still supported ? I see now that highlighting multiple lines is done using multiple instances of the --highlight-line argument, is there a reason this wasn't implemented the same was as the line-range argument ? To me that would seem more intuitive.

@sharkdp
Copy link
Owner Author

sharkdp commented Apr 4, 2019

s there a reason this wasn't implemented the same was as the line-range argument ? To me that would seem more intuitive.

Sounds like a great idea! Could you please open a new issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

highlight individual line
4 participants