Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDoc comments break syntax highlighting in .java files #81

Closed
eth-p opened this issue May 7, 2018 · 5 comments
Closed

JavaDoc comments break syntax highlighting in .java files #81

eth-p opened this issue May 7, 2018 · 5 comments
Labels
bug Something isn't working syntax-highlighting

Comments

@eth-p
Copy link
Collaborator

eth-p commented May 7, 2018

Version: bat 0.2.3
Platform: Mac OS X 10.13.4 (High Sierra)

JavaDoc comments in .java files break syntax highlighting for the rest of the file.
See the image below.

comparison

@eth-p eth-p changed the title JavaDoc Breaks Syntax Highlighting JavaDoc Comments Break Syntax Highlighting May 7, 2018
@eth-p eth-p changed the title JavaDoc Comments Break Syntax Highlighting JavaDoc comments break syntax highlighting in .java files May 7, 2018
@sharkdp sharkdp added bug Something isn't working syntax-highlighting labels May 8, 2018
@sharkdp
Copy link
Owner

sharkdp commented May 8, 2018

Thank you for taking the time to report this.

Here is an example file to reproduce this:

/**
 * test
 */
class ExampleClass {
}

@sharkdp
Copy link
Owner

sharkdp commented May 8, 2018

Reported upstream: trishume/syntect#160

@sharkdp
Copy link
Owner

sharkdp commented Sep 26, 2018

This has popped up multiple times now and basically affects every Java and D file. Until this has been fixed in syntect, maybe we could employ the fix suggested by @keith-hall here: trishume/syntect#160 (comment)

sharkdp added a commit that referenced this issue Oct 4, 2018
sharkdp added a commit that referenced this issue Oct 4, 2018
@sharkdp
Copy link
Owner

sharkdp commented Oct 4, 2018

Fixed via a2676cc

@sharkdp
Copy link
Owner

sharkdp commented Oct 17, 2018

Fixed in v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working syntax-highlighting
Projects
None yet
Development

No branches or pull requests

2 participants