Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start pager if file doesn't exist #387

Closed
E5ten opened this issue Oct 28, 2018 · 2 comments · Fixed by #450
Closed

Don't start pager if file doesn't exist #387

E5ten opened this issue Oct 28, 2018 · 2 comments · Fixed by #450
Labels
feature-request New feature or request

Comments

@E5ten
Copy link

E5ten commented Oct 28, 2018

If bat is called on a file that doesn't exist it opens up an empty pager instance and errors, instead of just erroring, I think it would be better if the pager wasn't opened unless the file exists.
@sharkdp
Copy link
Owner

sharkdp commented Oct 29, 2018

Thank you for the feedback.

Sounds sensible to me. Potentially, this is a little harder to fix than it might seem.

@sharkdp sharkdp added the feature-request New feature or request label Oct 29, 2018
sharkdp added a commit that referenced this issue Dec 14, 2018
@sharkdp
Omit launching of pager if NO file exists
53c85e1 
closes #387
@sharkdp sharkdp mentioned this issue Dec 14, 2018
Merged
sharkdp added a commit that referenced this issue Dec 14, 2018
@sharkdp
Omit launching of pager if NO file exists
397def1 
closes #387
@sharkdp
Copy link
Owner

sharkdp commented Feb 8, 2019

Fixed in v0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit launching of pager if NO file exists sharkdp/bat
2 participants
@sharkdp @E5ten