Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad regex regression introduced by #242 #246

Merged
merged 1 commit into from
Feb 27, 2020
Merged

fix: bad regex regression introduced by #242 #246

merged 1 commit into from
Feb 27, 2020

Conversation

sworisbreathing
Copy link
Contributor

Fixes #245 by making the path/label optional in the regex.
Added test coverage of the specific scenario reported in #242

eculver
eculver approved these changes Feb 27, 2020
View reviewed changes
Copy link

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly

@sworisbreathing
Copy link
Contributor Author

cheers. there are other issues with the regexes added in #242 but I wanted to limit the scope of my fix to just the issue I reported in #245

@nickatsegment nickatsegment changed the title #245 fix regression introduced by #242 fix: bad regex regression introduced by #242 Feb 27, 2020
@nickatsegment nickatsegment merged commit 99a1a98 into segmentio:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eculver eculver eculver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to validate service even though service name is valid
3 participants
@sworisbreathing @eculver @nickatsegment