Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow Interface] Fix for WorkspaceExport (Issue #1406) #1421

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

refai06
Copy link
Contributor

@refai06 refai06 commented Mar 4, 2025

Summary

This PR fixes an issue related with WorkspaceExport(#1406)

Type of Change (Mandatory)

  • Bug fix

Description (Mandatory)

Added flow instance name and modified the return statement to include both flow instance name and runtime instance

Testing

Validated below tutorial

  • openfl-tutorials/experimental/workflow/1001_Workspace_Creation_from_JupyterNotebook.ipynb

Copy link
Collaborator

@theakshaypant theakshaypant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this would also affect FLSpec refactor, would the respective PR (#1363 ) cover that?

@scngupta-dsp
Copy link
Contributor

Since this would also affect FLSpec refactor, would the respective PR (#1363 ) cover that?

@theakshaypant : This PR does not affect refactoring in #1363. Could you please elaborate your concern in more detail?

@teoparvanov
Copy link
Collaborator

teoparvanov commented Mar 6, 2025

Since this would also affect FLSpec refactor, would the respective PR (#1363 ) cover that?

@theakshaypant : This PR does not affect refactoring in #1363. Could you please elaborate your concern in more detail?

AFAIU, @theakshaypant refers to the fact that the FLSpec will no longer have a _runtime member variable as part of the #1363 refactoring.

Which additionally raises the question why @ishant162 doesn't modify the _find_runtime_instance() method accordingly?

raise AttributeError("Unable to locate LocalRuntime instantiation")
runtime = t._runtime
runtime = module_instance._runtime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teoparvanov Precisely! Per my understanding, this line would not work after the refactor since the Flow does not have a runtime associated with it.

@ishant162
Copy link
Collaborator

Since this would also affect FLSpec refactor, would the respective PR (#1363 ) cover that?

@theakshaypant : This PR does not affect refactoring in #1363. Could you please elaborate your concern in more detail?

AFAIU, @theakshaypant refers to the fact that the FLSpec will no longer have a _runtime member variable as part of the #1363 refactoring.

Which additionally raises the question why @ishant162 doesn't modify the _find_runtime_instance() method accordingly?

@teoparvanov, @theakshaypant,
The _find_runtime_instance() method supports the Aggregator-based workflow, where _runtime is still in use. Refactoring in #1363 focused on FederatedRuntime and LocalRuntime, with Aggregator workflow changes planned for a follow-up PR

Since the changes in this PR will be overridden by the follow-up PR maybe the issue resolution could wait for the follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants