-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow Interface] Fix for WorkspaceExport (Issue #1406) #1421
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: refai06 <[email protected]>
Signed-off-by: refai06 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this would also affect FLSpec
refactor, would the respective PR (#1363 ) cover that?
@theakshaypant : This PR does not affect refactoring in #1363. Could you please elaborate your concern in more detail? |
AFAIU, @theakshaypant refers to the fact that the Which additionally raises the question why @ishant162 doesn't modify the |
raise AttributeError("Unable to locate LocalRuntime instantiation") | ||
runtime = t._runtime | ||
runtime = module_instance._runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teoparvanov Precisely! Per my understanding, this line would not work after the refactor since the Flow does not have a runtime associated with it.
@teoparvanov, @theakshaypant, Since the changes in this PR will be overridden by the follow-up PR maybe the issue resolution could wait for the follow-up PR. |
Summary
This PR fixes an issue related with
WorkspaceExport
(#1406)Type of Change (Mandatory)
Description (Mandatory)
Added flow instance name and modified the return statement to include both flow instance name and runtime instance
Testing
Validated below tutorial
openfl-tutorials/experimental/workflow/1001_Workspace_Creation_from_JupyterNotebook.ipynb