-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Pytorch version updated to 2.5.1 #1357
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
…into pytorch-v-2.5.1
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we done any further investigation into why this redirection is necessary (i.e. why/when is pip._vendor.typing_extensions
being called to enforce parameter ordering as opposed to typing_extensions
)?
I know this was our originally proposed workaround, and I get that it might still be the only solution, but since we already needed to patch distutil
in order run torch==2.4.x
, I am very hesitant to introduce additional patches to get it working further.
My reason being that it is better for long term maintainability that we find a robust solution and avoid patching if we can.
Thank you @kta-intel for the review. closing this PR for now. |
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
Signed-off-by: yes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the pipelines, they have the parameter error.
Signed-off-by: yes <[email protected]>
Thank you for the review but this is still WIP. |
Signed-off-by: yes <[email protected]>
@teoparvanov, @kta-intel, @rahulga1. After investigating this issue in detail, the only solution other than a patch is to fix this in the |
Signed-off-by: yes <[email protected]>
Pytorch version updated to 2.5.1.
As we want to update PyTorch to version 2.5.1, we are proceeding with this PR along with a patch to fix the issue:
Type parameter +RV without a default follows type parameter with a default