Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing SQLAlchemy objects #94

Merged
merged 8 commits into from
Sep 5, 2021
Merged

Implement parsing SQLAlchemy objects #94

merged 8 commits into from
Sep 5, 2021

Conversation

aliereno
Copy link
Contributor

@aliereno aliereno commented Sep 4, 2021

Hi, I saw #72 issue and wanted to contribute.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #94 (bcc37ef) into master (66eaa80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files           7        7           
  Lines         506      513    +7     
  Branches       71       71           
=======================================
+ Hits          504      511    +7     
  Misses          2        2           
Impacted Files Coverage Δ
devtools/prettier.py 100.00% <100.00%> (ø)
devtools/utils.py 96.29% <100.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66eaa80...bcc37ef. Read the comment docs.

@alexmojaki
Copy link
Contributor

LGTM!

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thank you so much.

Just one small thing to fix.

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing I noticed, I'll add this, then merge.

@samuelcolvin samuelcolvin merged commit 746dfb2 into samuelcolvin:master Sep 5, 2021
@samuelcolvin
Copy link
Owner

Thanks so much for your contribution @aliereno, this will be really useful.

I'll create a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants