-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement parsing SQLAlchemy objects #94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 99.60% 99.61%
=======================================
Files 7 7
Lines 506 513 +7
Branches 71 71
=======================================
+ Hits 504 511 +7
Misses 2 2
Continue to review full report at Codecov.
|
Co-authored-by: Alex Hall <[email protected]>
Co-authored-by: Alex Hall <[email protected]>
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thank you so much.
Just one small thing to fix.
Co-authored-by: Samuel Colvin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing I noticed, I'll add this, then merge.
Thanks so much for your contribution @aliereno, this will be really useful. I'll create a new release soon. |
Hi, I saw #72 issue and wanted to contribute.