Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #1506: PNPM monorepo with pnpm-lock.yaml files. #1514

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Feb 24, 2025

This pull request includes significant changes to the typia project, focusing on dependency updates, the switch from npm to pnpm for package management, and the removal of deprecated components. Below are the most important changes:

Dependency Updates:

  • Added @types/body-parser and fp-ts to benchmark/package.json. [1] [2]
  • Updated body-parser to version 1.20.3 in benchmark/package.json.

Package Management:

  • Replaced npm commands with pnpm commands in deploy/index.ts and deploy/internal/DeployRunner.ts. [1] [2] [3] [4]

Removal of Deprecated Components:

  • Removed the ReplicaPublisher and its associated logic from deploy/internal/DeployRunner.ts and deploy/internal/ReplicaPublisher.ts. [1] [2]
  • Deleted the LICENSE and README.md files from the packages/typescript-json directory. [1] [2]

Package Configuration:

  • Updated the version and removed the private field in the root package.json. [1] [2]
  • Removed the typescript-json package configuration from packages/typescript-json/package.json.

These changes streamline the project by updating dependencies, improving package management, and removing deprecated components.

@samchon samchon added the enhancement New feature or request label Feb 24, 2025
@samchon samchon self-assigned this Feb 24, 2025
Copy link

pkg-pr-new bot commented Feb 24, 2025

Open in Stackblitz

npm i https://pkg.pr.new/typia@1514

commit: 40936b0

Copy link

socket-security bot commented Feb 24, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@fastify/[email protected] None 0 25.5 kB matteo.collina
npm/@rollup/[email protected] filesystem Transitive: environment, shell +42 4.46 MB shellscape
npm/@rollup/[email protected] Transitive: environment, filesystem +13 651 kB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/[email protected] environment, filesystem +10 587 kB shellscape
npm/@samchon/[email protected] network 0 1.92 MB samchon
npm/@sinclair/[email protected] None 0 536 kB sinclair
npm/@trivago/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +63 21.8 MB ayusharma
npm/@typegoose/[email protected] environment Transitive: eval, filesystem, network +27 11.9 MB hasezoey
npm/@types/[email protected] None 0 21.9 kB types
npm/@types/[email protected] None 0 9.24 kB types
npm/@types/[email protected] None +3 4.66 MB types
npm/@types/[email protected] None 0 3.23 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/@types/[email protected] None 0 6.74 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +104 16.5 MB bradzacher, jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +102 13.3 MB bradzacher, jameshenry
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +53 3.25 MB matteo.collina
npm/[email protected] eval +2 1.55 MB jdalton
npm/[email protected] None 0 776 kB typestack-release-bot
npm/[email protected] None +3 14.3 MB typestack-release-bot
npm/[email protected] environment Transitive: filesystem +12 253 kB cohara87
npm/[email protected] 🔁 npm/[email protected], npm/[email protected] None 0 174 kB abetomo
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, network, shell +35 4.01 MB mbostock
npm/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +108 13.6 MB gund
npm/[email protected] eval +6 687 kB jsumners
npm/[email protected] Transitive: environment, eval, filesystem +39 4.99 MB eomm
npm/[email protected] None 0 4.74 MB gcanti
npm/[email protected] None 0 460 kB gcanti
npm/[email protected] eval, filesystem, network, shell, unsafe Transitive: environment +64 8.45 MB domenic
npm/[email protected] shell 0 3.14 kB seb
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] filesystem, network +11 3.02 MB google-wombot
npm/[email protected] None 0 295 kB rbuckton
npm/[email protected] filesystem Transitive: environment +11 162 kB isaacs
npm/[email protected] None +1 2.72 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/[email protected] None 0 10.3 kB donovan_dmc
npm/[email protected] None +3 572 kB samchon
npm/[email protected] None 0 1.53 MB nonara
npm/[email protected] None +2 23.1 MB blakeembrey, jbrantly, johnnyreilly
npm/[email protected] environment, filesystem, unsafe +32 3.48 MB blakeembrey
npm/[email protected] None 0 2.58 MB samchon
npm/[email protected] filesystem 0 14.7 kB julianwowra
npm/[email protected] None +2 25.4 MB typedoc-bot
npm/[email protected] Transitive: network +2 28.6 MB samchon
npm/[email protected] None 0 123 kB ctavan
npm/[email protected] filesystem 0 26.4 kB gajus
npm/[email protected] None 0 699 kB colinhacks

View full report↗︎

Copy link

socket-security bot commented Feb 24, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/@babel/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryoppippi Succeeded to restore pnpm-lock.yaml, but bun is not working on pnpm monorepo.

@samchon samchon merged commit a1ccee9 into v8.0 Feb 24, 2025
10 checks passed
@samchon samchon deleted the feat/monorepo branch February 24, 2025 18:14
@ryoppippi
Copy link
Contributor

Oh yes.
Actually if you use pnpm we can ignore bun actually. I'll send a pr to delete bun later.

@ryoppippi
Copy link
Contributor

I'll work for removing Bun and fix rollup.config.js before v8.0
I have a work reaching the deadline rn, so please wait until next week.
BTW, I can't wait for next week!

@samchon

samchon added a commit that referenced this pull request Mar 1, 2025
* Prepare `@samchon/openapi` v3 update (#1507)

* Prepare next update of TypeScript (#1509)

* No more `typia patch` command required (#1510)

* Upgrade next version depepdency

* Close #1506: PNPM monorepo with `pnpm-lock.yaml` files. (#1514)

* Close #1506: PNPM monorepo with `pnpm-lock.yaml` files.

* Update workflows

* Fix build.yml

* Fix build.yml again

* Disable bun due to it does not support PNPM monorepo

* feat: remvoe bun action (#1520)

* Deprecate `llm.applicationOfValidate()` function. (#1524)

* Publish v8.0

---------

Co-authored-by: ryoppippi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants