SAK-49328 Profile Cannot change / add profile photo with profile2.avatar.initials.enabled=false #13422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tar.initials.enabled=false
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -228,9 +237,12 @@ export class SakaiPictureChanger extends SakaiElement { | |||
| <div id="image-editor-crop-wrapper"> | |||
| <div id="cropme"> | |||
| <input type="file" accept="image/*" value="Choose an image" @change=${this._filePicked} /> | |||
| <img id="image" src="${ifDefined(this._imageUrl)}"/> | |||
| ${this._imageUrl ? | |||
| html`<img id="image" class="max-width-100" src="${this._imageUrl}" />` : | |||
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
There was a problem hiding this comment.
I know this does not relate to the changes in this PR, so feel free to resolve this again. But I think the complain is valid here?
stetsche
reviewed
Mar 10, 2025
| } else { | ||
| this._attachCropper(); | ||
| } | ||
| this._needsSave = true; |
There was a problem hiding this comment.
do we need to move this._needsSave = true; into the callback, I think it could stay where it was?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked calude-3.7 inside cursor to edit this file. Its tested.