SAK-50468 Grader should scroll with instructor on desktop instead of overlaying

[ottenhoff]

TASKS:

• Works on desktop
• Works on mobile
• Works on iPad
• Remove the ability to Show All Feedback comment
• Removed "Grader" and put student name in header.
• DONE button should also do a SAVE? Not a Save and Release.
• Test dark mode vs light mode
• Hide Cancel button desktop (cant get rid of GRADER)
• Test on Firefox
• Test on Safari

[adrianfish]

I think the word Grader is ok, tbh. It just makes it clear that that is the grading area and doesn't really take up a load of space.
Remove is quicker than editing the text I think. Less clicks.

Generally, I was kind of expecting this JIRA. I think I went a bit too mobile first on it.

[ottenhoff]

Thanks. The mobile first is great. But yeah, power users are asking now .....

Remove is definitely quicker. I guess I wonder how often someone is removing entirely vs editing.

Obviously I'm trying to save screen real estate so that the GRADER panel can be fixed size

[wilmahodges]

Regarding the question about whether "Grader" should appear at the top, I think the way it looks in 22.x is preferable to the word "Grader" in shaded heading. I'd prefer to see the student photo next to name in that area. I think it is pretty clear that they are grading, so the word seems redundant. The student is the main thing you want to see, so it should be more prominent in the side panel. See screenshot of grading panel in 22.x attached for reference.

[wilmahodges]

Also, regarding if Done should also Save - Yes, I think selecting Done on the feedback window (or any of the other sections, such as Attachments, Private Notes, or Rubric) should save that section of feedback as well as any grades or other feedback entered so far. However, it should never Save and Release, only Save so the user doesn't lose any comments they have entered if they happen to select Done on a feedback section, but then forget to hit Save on the entire submission.

[wilmahodges]

For the "Remove" link, to save vertical screen space, couldn't you just put the Remove link to the right of the Edit button, instead of below the CKeditor part? When you Remove a rubric, the link is placed to the right of the Rubric button. This would make the placement more consistent within different feedback types in the grading panel.

[wilmahodges]

See mockup with my suggested changes