SAK-50968 Avoiding the use of CSS utility classes within webcomponents #13351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:) |
adrianfish
reviewed
Mar 3, 2025
library/src/skins/default/src/sass/webcomponents/sakai-notifications/_sakai-notifications.scss
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Mar 3, 2025
library/src/skins/default/src/sass/webcomponents/sakai-notifications/_sakai-notifications.scss
Outdated
Show resolved
Hide resolved
SedueRey
force-pushed
the
SAK-50968
branch
2 times, most recently
from
71e92f8 to
6303796
Compare
… to extend utility classes
adrianfish
reviewed
Mar 4, 2025
| @@ -49,7 +49,7 @@ export class SakaiRubricStudentComment extends RubricsElement { | |||
|
|
|||
| <div class="rubric-comment-dropdown dropdown-menu"> | |||
| <div class="m-2 rubric-comment-body"> | |||
| <div class="fw-bold rubric-criterion-comment-title">${this.tr("comment_for_criterion", [ this.criterion.title ])}</div> | |||
| <div class="rubric-criterion-comment-title">${this.tr("comment_for_criterion", [ this.criterion.title ])}</div> | |||
There was a problem hiding this comment.
I thought you were doing this task component by component? if you do them all like this QA will run a mile :) Too much to test at one time.
There was a problem hiding this comment.
Don't worry, I'll discuss it later in the Core Team call as well. You can count on the QA of all this by the Spanish institutions, we are very interested in having Sakai 25 to be able to migrate this summer.
I have to do a last review, but I think that all the changes that imply something for the corporate image are already in place.
It worries me a little that Codacy marks me as error those lines, since I am testing it and it works, it is a false positive, I think.
SedueRey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the webcomponents so that they can be customised for the corporate image of each of the institutions using Sakai.
Still a work in progress, I'll try to make a different commit for every single webcomponent should be updated.