feat: Improve ContractNetworksConfig
#1149
Open
+103
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13726052078Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves https://github.com/safe-global/developer-experience/issues/348
How this PR fixes it
Removes the ABIs from
ContractNetworkConfig. By removing the ABIs, we are taking them from the@safe-global/safe-deploymentspackage or via the default typeMakes all contract addresses in
ContractNetworkConfigoptional. This adds flexibility when instantiating the SDK with a custom addressUpgrade the
@safe-global/safe-passkeysby removing the alpha status and update theP256.Verifierstype, as it has changed since the alpha release we were using