Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies for support pydantic V2 and adapt code in consequences #195

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

fchancel
Copy link
Contributor

@fchancel fchancel commented Jul 9, 2023

Update pydantic to v2, fastapi to v0.100, email-validator to v2.0 packages.
Updated code according to pydantic V1 to V2 migration documentation.
Fix #194

@chrisK824
Copy link

@sabuhish this incompatibility is blocking updates into pydantic v2 which came out already with tons of enhancements.

Do you plan to merge this request and update dependencies or should we move out to some other solution?

@alexvhicks
Copy link

alexvhicks commented Jul 14, 2023

@sabuhish Need any help with this update? Currently blocking my team's update to Pydantic v2 as well. Let me know if I can help out anywhere.

@sabuhish
Copy link
Owner

sabuhish commented Jul 16, 2023

Thank you guys, for the report and work on it, changes LGTM. I would ask @fchancel to fix the linter please, it suppose to run on the pull request, but I realized it is manual work. Once it is fixed I will merge and realease it. Good work!

@fchancel fchancel force-pushed the support-pydantic-v2 branch from c21c9d6 to 7301799 Compare July 16, 2023 19:25
@fchancel
Copy link
Contributor Author

fchancel commented Jul 16, 2023

@sabuhish I fixed the linter. Only mypy errors persist. 32 already existing errors and an additional one due to the fact that mypy is not updated and therefore the expected formats for Pydantic do not correspond.

This new PR (#197) remove all mypy errors and alerts.

A re-reading of the modifications would be a plus to ensure a smooth transition from pydantic V1 to V2. Although I imagine the unit tests cover the essential cases.

@sabuhish
Copy link
Owner

Thank you for your work, sorry for being late and busy. I believe so also, many people are waiting for this PR to be merged, it is worth having it in the next release. I will have a look at your next PR too. Thanks again for your efforts, in helping the growth of this library!

@sabuhish sabuhish merged commit c15d24e into sabuhish:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pydantic v2
4 participants