Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11: Implement true cursor area with XNArea attribute #4158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x11: Implement true cursor area with XNArea attribute #4158

wants to merge 1 commit into from
+46 −36

Conversation

xorgy
Copy link
Contributor

@xorgy xorgy commented Mar 8, 2025

No description provided.

@xorgy
Copy link
Contributor Author

xorgy commented Mar 8, 2025

Sorry for all the pings! I meant to push my rebased branch instead of the one based on v0.30.9!

@xorgy
Copy link
Contributor Author

xorgy commented Mar 8, 2025 •
edited
Loading

I have a version of this branch that is backported to v0.30.9 so that I could test it against Alacritty v0.15.1.
v0.30.9...xorgy:xim-xnarea-0.30.9
I also have an Alacritty branch which is just v0.15.1 with the X11 cursor area workaround removed, and pulling winit from my v0.30.9-based version of this branch.

alacritty/alacritty@master...xorgy:alacritty:v0.15.1-sans-x11-cursor-area-workaround

@xorgy
Copy link
Contributor Author

xorgy commented Mar 9, 2025 •
edited
Loading

Note: you will need libx11 1.8.11 or later, and Fcitx5 5.1.11 or later in order to see this in action. On Fcitx5 you need to enable OnTheSpot mode in the XIM frontend settings (in the Addons tab under Frontend, in the Fcitx5 config tool).
The iBus maintainer is waiting on toolkit and application support before assessing merging the change to enable area on XIM, but Fcitx5 merged it before their current stable release.

@xorgy
Copy link
Contributor Author

xorgy commented Mar 9, 2025

Here is an example of this in action with (patched) Alacritty.

shui

kchibisov
kchibisov requested changes Mar 9, 2025
View reviewed changes
@MarijnS95 MarijnS95 removed their request for review March 9, 2025 18:12
@xorgy xorgy requested a review from kchibisov March 9, 2025 20:28
@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - x11 labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull Awaiting requested review from notgull notgull is a code owner

@kchibisov kchibisov Awaiting requested review from kchibisov kchibisov is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened DS - x11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorgy @kchibisov @madsmtm