macOS/iOS: Implement wake-ups using system mechanisms #4146
+154
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
changed the title
madsmtm
force-pushed
the
madsmtm/apple-proper-wakeup
branch
2 times, most recently
from
5732d82 to
3217bc1
Compare
kchibisov
requested changes
Mar 1, 2025
madsmtm
force-pushed
the
madsmtm/apple-proper-wakeup
branch
from
3217bc1 to
fde5fb5
Compare
kchibisov
approved these changes
Mar 1, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
8 tasks
|
Moved your comment to #4149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting an atomic in
wake_upand relying on it being propagated by the time the run loop wakes up is brittle, the proper way of usingCFRunLoopSourceis to do your work inside theperformcallback. This also automatically handles coalescing multiple events, and frees us from having to manually check an atomic on each iteration of the run loop.changelogmodule if knowledge of this change could be valuable to usersPart of #1029.