Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11: implement set_override_redirect #4125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lunixbochs
Copy link
Contributor

@lunixbochs lunixbochs commented Feb 11, 2025

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

implements window.set_override_redirect() for x11 so it can be updated after the window is created
(Note: I just ported this from my 0.30 branch to master without retesting and I'm not sure on the WindowExtX11 downcast)

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG entry.

@lunixbochs
Copy link
Contributor Author

added changelog entry and addressed comments

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all of these commits together.

@lunixbochs lunixbochs force-pushed the set-override-redirect branch from a9b67cd to 72dc152 Compare February 19, 2025 02:58
@lunixbochs lunixbochs requested a review from notgull February 19, 2025 02:59
@madsmtm madsmtm added DS - x11 S - platform parity Unintended platform differences labels Feb 24, 2025
@lunixbochs lunixbochs force-pushed the set-override-redirect branch from 72dc152 to 504c261 Compare March 10, 2025 14:00
@lunixbochs lunixbochs force-pushed the set-override-redirect branch from 504c261 to 03bab6a Compare March 10, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - x11 S - platform parity Unintended platform differences
Development

Successfully merging this pull request may close these issues.

4 participants