fix: invalid bit for detecting avx512 feature #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
silver-ymz
force-pushed
the
fix/avx512-detect
branch
from
ca59704 to
cc64079
Compare
usamoi
reviewed
Mar 2, 2024
| @@ -200,6 +206,7 @@ pub(crate) fn detect_features() -> cache::Initializer { | |||
| // For AVX-512 the OS also needs to support saving/restoring | |||
| // the extended state, only then we enable AVX-512 support: | |||
| if os_avx512_support { | |||
| enable(extended_features_eax, 5, Feature::avx512bf16); | |||
There was a problem hiding this comment.
According to the reference, we should get this bit in the output eax register of __cpuid_count(7, 1).
There was a problem hiding this comment.
fixed in new commit
Signed-off-by: Mingzhuo Yin <[email protected]>
Signed-off-by: Mingzhuo Yin <[email protected]>
Amanieu
force-pushed
the
fix/avx512-detect
branch
from
93f7697 to
caca7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://www.intel.com/content/dam/develop/external/us/en/documents/architecture-instruction-set-extensions-programming-reference.pdf
avx512vp2intersectis on page 26,avx512bf16is on page 27