Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings for sleep_ms #40

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Fix deprecation warnings for sleep_ms #40

merged 1 commit into from
Jan 11, 2016
+2 −1

Conversation

jwilm
Copy link
Contributor

@jwilm jwilm commented Dec 17, 2015

std::thread::sleep_ms has been deprecated in favor of std::thread::sleep with a std::time::Duration being passed as the argument. This updates all usage in this project of sleep_ms with sleep.

@jwilm
Copy link
Contributor Author

jwilm commented Dec 17, 2015

Hmm... both of my PRs seemed OK on my machine. Looking through the travis log, it looks like it can no longer find docker. This causes the release build to fail and subsequently tests/cli.sh.

@jwilm
Copy link
Contributor Author

jwilm commented Dec 17, 2015

This appears to be the problem on appveyor:

LINK : fatal error LNK1181: cannot open input file 'ws2_32.lib'

@Diggsey
Copy link
Contributor

Diggsey commented Jan 3, 2016

Hi @jwilm, sorry for taking so long on this - didn't have time to figure out what was up with the CI. @trolleyman's PR has fixed the appveyor builds, so I'm happy to merge this if you could fix the merge conflicts (his PR also addressed one of the occurences of sleep_ms).

Thanks!

@jwilm
Fix deprecation warnings for sleep_ms
793445a 
std::thread::sleep_ms has been deprecated in favor of std::thread::sleep
with a std::time::Duration being passed as the argument. This updates
all usage in this project of sleep_ms with sleep.
@jwilm jwilm force-pushed the fix-deprecation-warnings branch from 47df177 to 793445a Compare January 11, 2016 16:30
@jwilm
Copy link
Contributor Author

jwilm commented Jan 11, 2016

Just rebased. It looks like tests are failing on master, so they will probably fail here too. Will take a look after the CI updates the build status.

@Diggsey
Copy link
Contributor

Diggsey commented Jan 11, 2016

@jwilm Don't worry, the recent failures are due to the rand crate failing to build on the most recent rust nightly.

Diggsey added a commit that referenced this pull request Jan 11, 2016
@Diggsey
Merge pull request #40 from jwilm/fix-deprecation-warnings
abb069a 
Fix deprecation warnings for sleep_ms
@Diggsey Diggsey merged commit abb069a into rust-lang:master Jan 11, 2016
@jwilm
Copy link
Contributor Author

jwilm commented Jan 11, 2016

Cool, thanks for merge then.

@jwilm jwilm deleted the fix-deprecation-warnings branch January 11, 2016 16:45
djc added a commit that referenced this pull request Jun 18, 2024
@djc
# This is a combination of 40 commits.
97dd0be 
# This is the 1st commit message:

Port cli_inst_interactive to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #20 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #21 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #22 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #23 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #24 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #25 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #26 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #27 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #28 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #29 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #30 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #31 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #32 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #33 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #34 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #35 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #36 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #37 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #38 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #39 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #40 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwilm @Diggsey