DOC: remove unnecessary feature crate attribute from example code #87422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 7879a59 has been approved by |
bors
added
S-waiting-on-bors
This feature attribute was actually added in #86344. I can imagine that the PR author tested their example in e.g. the playground and forgot to remove the feature gate afterwards. Also, if you want to know more about the stabilization process for library feature there is a chapter in the std-dev-guide that you can read. |
LeSeulArtichaut
added a commit
to LeSeulArtichaut/rust
that referenced
this pull request
Jul 24, 2021
… r=LeSeulArtichaut DOC: remove unnecessary feature crate attribute from example code I'm not sure whether I fully understand the stabilization process (I most likely don't), but I think this attribute isn't necessary here, right? This was recently stabilized in rust-lang#86344.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 24, 2021
… r=LeSeulArtichaut DOC: remove unnecessary feature crate attribute from example code I'm not sure whether I fully understand the stabilization process (I most likely don't), but I think this attribute isn't necessary here, right? This was recently stabilized in rust-lang#86344.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 24, 2021
…arth Rollup of 9 pull requests Successful merges: - rust-lang#87348 (Fix span when suggesting to add an associated type bound) - rust-lang#87359 (Remove detection of rustup and cargo in 'missing extern crate' diagnostics) - rust-lang#87370 (Add support for powerpc-unknown-freebsd) - rust-lang#87389 (Rename `known_attrs` to `expanded_inert_attrs` and move to rustc_expand) - rust-lang#87395 (Clear up std::env::set_var panic section.) - rust-lang#87403 (Implement `AssignToDroppingUnionField` in THIR unsafeck) - rust-lang#87410 (Mark `format_args_nl` as `#[doc(hidden)]`) - rust-lang#87419 (IEEE 754 is not an RFC) - rust-lang#87422 (DOC: remove unnecessary feature crate attribute from example code) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Yeah that's precisely what happened 🤣 . good catch @mgeier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether I fully understand the stabilization process (I most likely don't), but I think this attribute isn't necessary here, right?
This was recently stabilized in #86344.